spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lianhuiwang <...@git.apache.org>
Subject [GitHub] spark pull request #18205: [SPARK-20986] [SQL] Reset table's statistics afte...
Date Mon, 12 Jun 2017 12:26:57 GMT
Github user lianhuiwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18205#discussion_r121378281
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/PruneFileSourcePartitionsSuite.scala
---
    @@ -66,4 +68,42 @@ class PruneFileSourcePartitionsSuite extends QueryTest with SQLTestUtils
with Te
           }
         }
       }
    +
    +  test("SPARK-20986 Reset table's statistics after PruneFileSourcePartitions rule") {
    +    withTempView("tempTbl") {
    +      withTable("partTbl") {
    +        spark.range(1000).selectExpr("id").createOrReplaceTempView("tempTbl")
    +        sql("CREATE TABLE partTbl (id INT) PARTITIONED BY (part INT) STORED AS parquet")
    +        for (part <- Seq(1, 2, 3)) {
    +          sql(
    +            s"""
    +               |INSERT OVERWRITE TABLE partTbl PARTITION (part='$part')
    +               |select id from tempTbl
    +            """.stripMargin)
    +        }
    +
    +        val tableName = "partTbl"
    +        sql(s"analyze table partTbl compute STATISTICS")
    +
    +        val tableStats =
    +          spark.sessionState.catalog.getTableMetadata(TableIdentifier(tableName)).stats
    +        assert(tableStats.isDefined && tableStats.get.sizeInBytes > 0, "tableStats
is lost")
    +
    +        withSQLConf(SQLConf.ENABLE_FALL_BACK_TO_HDFS_FOR_STATS.key -> "true") {
    +          val df = sql("SELECT * FROM partTbl where part = 1")
    +          val query = df.queryExecution.analyzed.analyze
    --- End diff --
    
    Because there is SubqueryAlias plan, I think that we need analyze() to eliminate it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message