spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...
Date Wed, 07 Jun 2017 23:24:26 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17723#discussion_r120758091
  
    --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/YARNConfigurableCredentialManager.scala
---
    @@ -0,0 +1,87 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.deploy.yarn.security
    +
    +import java.util.ServiceLoader
    +
    +import scala.collection.JavaConverters._
    +
    +import org.apache.hadoop.conf.Configuration
    +import org.apache.hadoop.fs.FileSystem
    +import org.apache.hadoop.security.Credentials
    +
    +import org.apache.spark.SparkConf
    +import org.apache.spark.deploy.security.ConfigurableCredentialManager
    +import org.apache.spark.internal.Logging
    +import org.apache.spark.util.Utils
    +
    +
    +/**
    + * This class loads credential providers registered under the YARN-specific
    + * [[ServiceCredentialProvider]] interface, as well as the builtin credential providers
defined
    + * in [[ConfigurableCredentialManager]].
    + */
    +private[yarn] class YARNConfigurableCredentialManager(
    +    sparkConf: SparkConf,
    +    hadoopConf: Configuration,
    +    fileSystems: Set[FileSystem]) extends Logging {
    +
    +  private val configurableCredentialManager =
    +    new ConfigurableCredentialManager(sparkConf, hadoopConf, fileSystems)
    +
    +  // public for testing
    +  val credentialProviders = getCredentialProviders
    +
    +  def obtainYARNCredentials(
    +    hadoopConf: Configuration,
    +    creds: Credentials): Long = {
    +
    +    val superInterval = configurableCredentialManager.obtainCredentials(
    +      hadoopConf,
    +      creds)
    +
    +    credentialProviders.values.flatMap { provider =>
    +      if (provider.credentialsRequired(hadoopConf)) {
    +        provider.obtainCredentials(hadoopConf, sparkConf, creds)
    +      } else {
    +        logDebug(s"Service ${provider.serviceName} does not require a token." +
    +          s" Check your configuration to see if security is disabled or not.")
    +        None
    +      }
    +    }.foldLeft(superInterval)(math.min)
    +  }
    +
    +  private def getCredentialProviders:
    +    Map[String, ServiceCredentialProvider] = {
    +    val providers = loadCredentialProviders
    +
    +    providers.
    +      filter { p => configurableCredentialManager.isServiceEnabled(p.serviceName)
}
    --- End diff --
    
    Hmm... code reuse is nice and all, but this is deprecating the configurations currently
used by the YARN extensions for no good reason. Better to keep a separate `isServiceEnabled`
for this class, and then the other one can be made private.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message