spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark issue #18004: [SPARK-18838][CORE] Introduce blocking strategy for Live...
Date Fri, 02 Jun 2017 21:30:50 GMT
Github user vanzin commented on the issue:

    https://github.com/apache/spark/pull/18004
  
    I'm more fond of an approach like #16291, but the owner of that PR seems to have abandoned
it.
    
    You seem to be singling out the event log listener here, while other listeners can be
just as harmful; the UI listeners to synchronization and can block the bus when a UI request
comes in, for example.
    
    Having separate buses for groups of listeners is a more generic way of doing what you
did for the event logger here. Then you could potentially have different configs for each
group (e.g. allow the event log thread to back up a bit more), although maybe that's overkill.
    
    BTW you don't even call out the event logging listener changes in your PR description.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message