spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #18143: [SPARK-20919][SS] Simplificaiton of CachedKafkaCo...
Date Thu, 01 Jun 2017 09:03:28 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18143#discussion_r119562656
  
    --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala
---
    @@ -45,9 +46,6 @@ private[kafka010] case class CachedKafkaConsumer private(
     
       private var consumer = createConsumer
     
    -  /** indicates whether this consumer is in use or not */
    -  private var inuse = true
    --- End diff --
    
    Don't we need to track this anymore? Will we evict a consumer in use?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message