spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ajbozarth <...@git.apache.org>
Subject [GitHub] spark pull request #18170: [SPARK-20942]The title style about field is error...
Date Thu, 01 Jun 2017 03:41:37 GMT
Github user ajbozarth commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18170#discussion_r119522502
  
    --- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage-template.html
---
    @@ -20,17 +20,17 @@
       <thead>
         <tr>
           <th>
    -        <span data-toggle="tooltip" data-placement="right" title="ID of the application.">
    +        <span data-toggle="tooltip" data-placement="right" title="ID of this application.">
               App ID
             </span>
           </th>
           <th>
    -        <span data-toggle="tooltip" data-placement="above" title="Name of the application.">
    +        <span data-toggle="tooltip" data-placement="right" title="Name of this application.">
               App Name
             </span>
           </th>
           <th class="attemptIDSpan">
    -        <span data-toggle="tooltip" data-placement="above" title="The attempt ID of
this application since one application might be launched several times">
    +        <span data-toggle="tooltip" data-placement="right" title="The attempt ID of
this application since one application might be launched several times">
    --- End diff --
    
    ah I found the issue, `above` is incorrect, what we want is `top`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message