Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: kiszk <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-18136-spark@git.apache.org>
In-Reply-To: <git-pr-18136-spark@git.apache.org>
Subject: [GitHub] spark pull request #18136: [SPARK-20910][SQL] Add build-int SQL function - U...
Content-Type: text/plain
Message-Id: <20170531163950.B9D7DDFC2E@git1-us-west.apache.org>
Date: Wed, 31 May 2017 16:39:50 +0000 (UTC)
archived-at: Wed, 31 May 2017 16:39:52 -0000

Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18136#discussion_r119409458
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala ---
    @@ -104,3 +107,26 @@ case class CurrentDatabase() extends LeafExpression with Unevaluable {
       override def nullable: Boolean = false
       override def prettyName: String = "current_database"
     }
    +
    +// scalastyle:off line.size.limit
    +@ExpressionDescription(
    +  usage = "_FUNC_() - Returns a universally unique identifier (UUID) string. The value is returned as a canonical UUID 36-character string.",
    +  extended = """
    +    Examples:
    +      > SELECT _FUNC_();
    +       46707d92-02f4-4817-8116-a4c3b23e6266
    +  """)
    +// scalastyle:on line.size.limit
    +case class Uuid() extends LeafExpression {
    +
    +  override def nullable: Boolean = false
    +
    +  override def dataType: DataType = StringType
    +
    +  override def eval(input: InternalRow): Any = UTF8String.fromString(UUID.randomUUID().toString)
    +
    +  override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
    +    ev.copy(code = s"final ${ctx.javaType(dataType)} ${ev.value} = " +
    --- End diff --
    
    nit: ${ctx.javaType(dataType)} -> UTF8String


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org