Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: wzhfy <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-12646-spark@git.apache.org>
In-Reply-To: <git-pr-12646-spark@git.apache.org>
Subject: [GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...
Content-Type: text/plain
Message-Id: <20170526075004.EC55FE9622@git1-us-west.apache.org>
Date: Fri, 26 May 2017 07:50:04 +0000 (UTC)
archived-at: Fri, 26 May 2017 07:50:07 -0000

Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12646#discussion_r118625884
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ---
    @@ -1077,7 +1080,8 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging
           case expressions =>
             expressions
         }
    -    val function = UnresolvedFunction(visitFunctionName(ctx.qualifiedName), arguments, isDistinct)
    +    val function = UnresolvedFunction(visitFunctionName(ctx.qualifiedName, trimFuncName),
    --- End diff --
    
    Can we do the function renaming here? What we want is just to replace `funcName` in `FunctionIdentifier`, we can put this logic here, then we don't need to change the definition of `def visitFunctionName`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org