Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: heary-cao <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-18057-spark@git.apache.org>
In-Reply-To: <git-pr-18057-spark@git.apache.org>
Subject: [GitHub] spark pull request #18057: [SPARK-20786][SQL][Backport-2.2]Improve ceil and ...
Content-Type: text/plain
Message-Id: <20170525023044.0D46DDFF66@git1-us-west.apache.org>
Date: Thu, 25 May 2017 02:30:44 +0000 (UTC)
archived-at: Thu, 25 May 2017 02:30:46 -0000

Github user heary-cao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18057#discussion_r118406121
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala ---
    @@ -347,9 +348,10 @@ case class Floor(child: Expression) extends UnaryMathExpression(math.floor, "FLO
       }
     
       override def inputTypes: Seq[AbstractDataType] =
    -    Seq(TypeCollection(DoubleType, DecimalType))
    +    Seq(TypeCollection(LongType, DoubleType, DecimalType))
    --- End diff --
    
    The default type should be DoubleType


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org