Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: 10110346 <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-17997-spark@git.apache.org>
In-Reply-To: <git-pr-17997-spark@git.apache.org>
Subject: [GitHub] spark pull request #17997: [SPARK-20763][SQL]The function of `month` and `da...
Content-Type: text/plain
Message-Id: <20170518042104.D314DDFE61@git1-us-west.apache.org>
Date: Thu, 18 May 2017 04:21:04 +0000 (UTC)
archived-at: Thu, 18 May 2017 04:21:07 -0000

Github user 10110346 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17997#discussion_r117158477
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala ---
    @@ -76,6 +76,9 @@ class DateExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
           }
         }
         checkEvaluation(DayOfYear(Literal.create(null, DateType)), null)
    +
    +    checkEvaluation(DayOfYear(Literal(new Date(sdf.parse("1582-10-15 13:10:15").getTime))), 288)
    --- End diff --
    
    OK, thanks @cloud-fan 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org