spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rednaxelafx <...@git.apache.org>
Subject [GitHub] spark pull request #18095: [SPARK-20872][SQL] ShuffleExchange.nodeName shoul...
Date Wed, 24 May 2017 18:52:37 GMT
GitHub user rednaxelafx opened a pull request:

    https://github.com/apache/spark/pull/18095

    [SPARK-20872][SQL] ShuffleExchange.nodeName should handle null coordinator

    ## What changes were proposed in this pull request?
    
    A one-liner change in `ShuffleExchange.nodeName` to cover the case when `coordinator`
is `null`, so that the match expression is exhaustive.
    
    Please refer to [SPARK-20872](https://issues.apache.org/jira/browse/SPARK-20872) for a
description of the symptoms.
    
    ## How was this patch tested?
    
    Manually tested this change with a case where the `coordinator` is null to make sure `ShuffleExchange.nodeName`
doesn't throw a `MatchError` any more.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rednaxelafx/apache-spark shuffleexchange-nodename

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18095.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18095
    
----
commit 23aff2a468b9b1522f6520489bdca2ee7389a10a
Author: Kris Mok <kris.mok@databricks.com>
Date:   2017-05-24T18:44:43Z

    SPARK-20872: make ShuffleExchange.nodeName handle null coordinator

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message