spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #18129: [SPARK-20365][YARN] Remove LocalSchem when add pa...
Date Wed, 31 May 2017 16:52:11 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18129#discussion_r119412348
  
    --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala
---
    @@ -119,12 +119,13 @@ class ClientSuite extends SparkFunSuite with Matchers with BeforeAndAfterAll
           if (LOCAL_SCHEME.equals(uri.getScheme())) {
             cp should contain (uri.getPath())
           } else {
    -        cp should not contain (uri.getPath())
    +        cp should not contain uri.getPath()
    --- End diff --
    
    Could you avoid these noisy changes and also keep the existing style of using parentheses
in the code you're actually adding?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message