spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #17617: [SPARK-20244][Core] Handle incorrect bytesRead me...
Date Wed, 31 May 2017 05:39:03 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17617#discussion_r119274153
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala ---
    @@ -143,14 +144,18 @@ class SparkHadoopUtil extends Logging {
        * Returns a function that can be called to find Hadoop FileSystem bytes read. If
        * getFSBytesReadOnThreadCallback is called from thread r at time t, the returned callback
will
        * return the bytes read on r since t.
    -   *
    -   * @return None if the required method can't be found.
        */
       private[spark] def getFSBytesReadOnThreadCallback(): () => Long = {
    --- End diff --
    
    let's update the document to say that, the returned function may be called in multiple
threads.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message