spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...
Date Sun, 28 May 2017 03:53:54 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18086#discussion_r118832568
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/hints.scala
---
    @@ -25,7 +25,7 @@ import org.apache.spark.sql.internal.SQLConf
      * should be removed This node will be eliminated post analysis.
      * A pair of (name, parameters).
      */
    -case class UnresolvedHint(name: String, parameters: Seq[String], child: LogicalPlan)
    +case class UnresolvedHint(name: String, parameters: Seq[Any], child: LogicalPlan)
    --- End diff --
    
    To support multiple parameters in `hint`, does it make sense to do it like `df.hint("hint",
"1, 2, c")`? We can use our Parser to parse this parameter string. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message