spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #18034: [SPARK-20797][MLLIB]fix LocalLDAModel.save() bug.
Date Mon, 22 May 2017 13:30:46 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18034#discussion_r117745103
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala ---
    @@ -468,7 +469,16 @@ object LocalLDAModel extends Loader[LocalLDAModel] {
           val topics = Range(0, k).map { topicInd =>
             Data(Vectors.dense((topicsDenseMatrix(::, topicInd).toArray)), topicInd)
           }
    -      spark.createDataFrame(topics).repartition(1).write.parquet(Loader.dataPath(path))
    +
    +      val bufferSize = Utils.byteStringAsBytes(
    +        spark.conf.get("spark.kryoserializer.buffer.max", "64m"))
    +      // We calculate the approximate size of the model
    +      // We only calculate the array size, considering an
    +      // average string size of 15 bytes, the formula is:
    +      // (floatSize * vectorSize + 15) * numWords
    +      val approxSize = (4L * k + 15) * topicsMatrix.numRows
    +      val nPartitions = ((approxSize / bufferSize) + 1).toInt
    +      spark.createDataFrame(topics).repartition(nPartitions).write.parquet(Loader.dataPath(path))
    --- End diff --
    
    @d0evi1 I'm not sure how that's related to my comment.
    @hhbyyh what do you think -- am I wrong about the issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message