spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From 10110346 <...@git.apache.org>
Subject [GitHub] spark pull request #17997: [SPARK-20763][SQL]The function of `month` and `da...
Date Thu, 18 May 2017 07:51:16 GMT
Github user 10110346 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17997#discussion_r117180644
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
    @@ -603,7 +603,13 @@ object DateTimeUtils {
        */
       private[this] def getYearAndDayInYear(daysSince1970: SQLDate): (Int, Int) = {
         // add the difference (in days) between 1.1.1970 and the artificial year 0 (-17999)
    -    val daysNormalized = daysSince1970 + toYearZero
    +    var  daysSince1970Tmp = daysSince1970
    +    // In history,the period(5.10.1582 ~ 14.10.1582) is not exist
    --- End diff --
    
    @gatorsmile ok,thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message