spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request #16989: [SPARK-19659] Fetch big blocks to disk when shuff...
Date Thu, 18 May 2017 07:20:50 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16989#discussion_r117174623
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
    @@ -193,8 +217,19 @@ private[spark] object HighlyCompressedMapStatus {
         } else {
           0
         }
    +    val threshold = SparkEnv.get.conf.get(config.SHUFFLE_ACCURATE_BLOCK_THRESHOLD)
    +    val hugeBlockSizesArray = ArrayBuffer[Tuple2[Int, Byte]]()
    --- End diff --
    
    If you're only going to be using `avgSize` for the non-huge blocks then I think you'd
want to remove the huge blocks from the numerator in that calculation so that you more accurately
size the smaller blocks, that way you're left with `averageOfNonEmptyNonHugeBlocks, preciseSizesOfHugeBlocks`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message