spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinxing64 <...@git.apache.org>
Subject [GitHub] spark pull request #16989: [SPARK-19659] Fetch big blocks to disk when shuff...
Date Tue, 09 May 2017 15:36:58 GMT
Github user jinxing64 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16989#discussion_r115523103
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
    @@ -154,15 +164,24 @@ final class ShuffleBlockFetcherIterator(
         while (iter.hasNext) {
           val result = iter.next()
           result match {
    -        case SuccessFetchResult(_, address, _, buf, _) =>
    +        case SuccessFetchResult(_, address, size, buf, _) =>
               if (address != blockManager.blockManagerId) {
                 shuffleMetrics.incRemoteBytesRead(buf.size)
                 shuffleMetrics.incRemoteBlocksFetched(1)
               }
               buf.release()
    +          freeMemory(size)
             case _ =>
           }
         }
    +    shuffleFiles.foreach { shuffleFile =>
    +      try {
    +        shuffleFile.delete()
    +      } catch {
    +        case ioe: IOException =>
    +          logError(s"Failed to cleanup ${shuffleFile.getAbsolutePath}.", ioe)
    --- End diff --
    
    Yes, sorry for the mistake


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message