spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinxing64 <...@git.apache.org>
Subject [GitHub] spark pull request #16989: [SPARK-19659] Fetch big blocks to disk when shuff...
Date Tue, 09 May 2017 15:25:30 GMT
Github user jinxing64 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16989#discussion_r115519964
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
    @@ -128,41 +130,52 @@ private[spark] class CompressedMapStatus(
      * @param numNonEmptyBlocks the number of non-empty blocks
      * @param emptyBlocks a bitmap tracking which blocks are empty
      * @param avgSize average size of the non-empty blocks
    + * @param hugeBlockSizesArray sizes of huge blocks by their reduceId.
      */
     private[spark] class HighlyCompressedMapStatus private (
         private[this] var loc: BlockManagerId,
         private[this] var numNonEmptyBlocks: Int,
         private[this] var emptyBlocks: RoaringBitmap,
    -    private[this] var avgSize: Long)
    +    private[this] var avgSize: Long,
    +    private[this] var hugeBlockSizesArray: Array[Tuple2[Int, Byte]])
       extends MapStatus with Externalizable {
     
    +  @transient var hugeBlockSizes: Map[Int, Byte] =
    +    if (hugeBlockSizesArray == null) null else hugeBlockSizesArray.toMap
    +
       // loc could be null when the default constructor is called during deserialization
       require(loc == null || avgSize > 0 || numNonEmptyBlocks == 0,
         "Average size can only be zero for map stages that produced no output")
     
    -  protected def this() = this(null, -1, null, -1)  // For deserialization only
    +  protected def this() = this(null, -1, null, -1, null)  // For deserialization only
     
       override def location: BlockManagerId = loc
     
       override def getSizeForBlock(reduceId: Int): Long = {
         if (emptyBlocks.contains(reduceId)) {
           0
         } else {
    -      avgSize
    +      hugeBlockSizes.get(reduceId) match {
    --- End diff --
    
    Yes, I should refine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message