spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhengruifeng <...@git.apache.org>
Subject [GitHub] spark issue #17910: [SPARK-20669][ML] LogisticRegression family should be ca...
Date Tue, 09 May 2017 07:45:13 GMT
Github user zhengruifeng commented on the issue:

    https://github.com/apache/spark/pull/17910
  
    @hhbyyh I find that param in `ALS` and `treeParams` is lowered in the getter, and the
getter instead of the param is used in the algs.
    https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala#L125
    
    https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala#L236
    
    I think it maybe better to follow this way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message