spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mridulm <...@git.apache.org>
Subject [GitHub] spark pull request #16989: [SPARK-19659] Fetch big blocks to disk when shuff...
Date Tue, 09 May 2017 06:00:52 GMT
Github user mridulm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16989#discussion_r115409843
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
    @@ -128,41 +130,52 @@ private[spark] class CompressedMapStatus(
      * @param numNonEmptyBlocks the number of non-empty blocks
      * @param emptyBlocks a bitmap tracking which blocks are empty
      * @param avgSize average size of the non-empty blocks
    + * @param hugeBlockSizesArray sizes of huge blocks by their reduceId.
      */
     private[spark] class HighlyCompressedMapStatus private (
         private[this] var loc: BlockManagerId,
         private[this] var numNonEmptyBlocks: Int,
         private[this] var emptyBlocks: RoaringBitmap,
    -    private[this] var avgSize: Long)
    +    private[this] var avgSize: Long,
    +    private[this] var hugeBlockSizesArray: Array[Tuple2[Int, Byte]])
    --- End diff --
    
    Why does hugeBlockSizesArray exist ? Is it for efficient serializable ?
    If yes, the then converting it into (Array[Int], Array[Byte]) would be better (with each
array written directly - not as Tupe2 object) - more below though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message