spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #17901: [SPARK-20639][SQL] Add single argument support fo...
Date Tue, 09 May 2017 04:03:14 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17901#discussion_r115403383
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
    @@ -1212,22 +1209,27 @@ case class ParseToDate(left: Expression, format: Option[Expression],
child: Expr
     /**
      * Parses a column to a timestamp based on the supplied format.
      */
    -// scalastyle:off line.size.limit
     @ExpressionDescription(
    -  usage = "_FUNC_(timestamp, fmt) - Parses the `left` expression with the `format` expression
to a timestamp. Returns null with invalid input.",
    +  usage = """
    +    _FUNC_(timestamp[, fmt]) - Parses the `timestamp` expression with the `format` expression
to
    +      a timestamp. Returns null with invalid input. Default `fmt` is 'yyyy-MM-dd HH:mm:ss'.
    --- End diff --
    
    Sure, let me give a shot.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message