spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <...@git.apache.org>
Subject [GitHub] spark issue #17845: [SPARK-20587][ML] Improve performance of ML ALS recommen...
Date Mon, 08 May 2017 21:05:46 GMT
Github user jkbradley commented on the issue:

    https://github.com/apache/spark/pull/17845
  
    One more comment I'll copy from the other PR: I'm not a fan of custom BLAS implementations
scattered throughout MLlib. Could you please follow up by putting the dot as a private API
in BLAS.scala and adding unit tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message