spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #17890: [MINOR][BUILD] Fix lint-java breaks.
Date Mon, 08 May 2017 11:02:38 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17890#discussion_r115222829
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
---
    @@ -379,7 +379,7 @@ final class DataStreamWriter[T] private[sql](ds: Dataset[T]) {
     
       private var outputMode: OutputMode = OutputMode.Append
     
    -  private var trigger: Trigger = Trigger.ProcessingTime(0L)
    +  private var trigger: Trigger = Trigger.processingTime(0L)
    --- End diff --
    
    OK @ConeyLiu . We can't make this change in any event. If you can get the rule I added
working, great, otherwise, just comment on it and ignore it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message