spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #17713: [SPARK-20417][SQL] Move subquery error handling t...
Date Sun, 07 May 2017 21:15:15 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17713#discussion_r115154225
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
    @@ -386,16 +386,12 @@ trait CheckAnalysis extends PredicateHelper {
     
         // Skip subquery aliases added by the Analyzer.
         // For projects, do the necessary mapping and skip to its child.
    -    def cleanQuery(p: LogicalPlan): LogicalPlan = p match {
    -      case s: SubqueryAlias => cleanQuery(s.child)
    -      case p: Project => cleanQuery(p.child)
    +    def cleanScalarQuery(p: LogicalPlan): LogicalPlan = p match {
    --- End diff --
    
    How about `cleanQueryInScalarSubquery`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message