spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #17865: [SPARK-20456][Docs] Add examples for functions co...
Date Fri, 05 May 2017 04:36:30 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17865#discussion_r114930366
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -793,8 +824,8 @@ def date_format(date, format):
         .. note:: Use when ever possible specialized functions like `year`. These benefit
from a
             specialized implementation.
     
    -    >>> df = spark.createDataFrame([('2015-04-08',)], ['a'])
    -    >>> df.select(date_format('a', 'MM/dd/yyy').alias('date')).collect()
    +    >>> df = spark.createDataFrame([('2015-04-08',)], ['time'])
    --- End diff --
    
    Okay. I guess it is a documentation improvement to use a bit more meaningful name over
an arbitrary name `a`. Let's match these to existing names such as `ts` or `t` (abbreviation
for timestamp) or `dt` (abbreviation for `datetime.datetime`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message