Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C4A76200C62 for ; Wed, 26 Apr 2017 16:37:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C33FA160BA8; Wed, 26 Apr 2017 14:37:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0DB78160B95 for ; Wed, 26 Apr 2017 16:37:05 +0200 (CEST) Received: (qmail 73254 invoked by uid 500); 26 Apr 2017 14:37:05 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 73235 invoked by uid 99); 26 Apr 2017 14:37:05 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Apr 2017 14:37:05 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C9A10E1103; Wed, 26 Apr 2017 14:37:04 +0000 (UTC) From: maropu To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark issue #17191: [SPARK-14471][SQL] Aliases in SELECT could be used in GR... Content-Type: text/plain Message-Id: <20170426143704.C9A10E1103@git1-us-west.apache.org> Date: Wed, 26 Apr 2017 14:37:04 +0000 (UTC) archived-at: Wed, 26 Apr 2017 14:37:07 -0000 Github user maropu commented on the issue: https://github.com/apache/spark/pull/17191 I tried to move `ResolveOrdinalInOrderByAndGroupBy` and `ResolveAggAliasInGroupBy` into `postHocResolutionRules`, but I found I got some exceptions in `SQLQueryTestSuite`. To solve the exceptions, we need to move some rules there, too (e.g., `ResolveMissingReferences`, `ResolveSubquery`, and `ResolveAggregateFunctions`). WDYT? cc: @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org