Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: koertkuipers <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-17660-spark@git.apache.org>
In-Reply-To: <git-pr-17660-spark@git.apache.org>
Subject: [GitHub] spark issue #17660: [SPARK-20359][SQL] catch NPE in EliminateOuterJoin optim...
Content-Type: text/plain
Message-Id: <20170418115311.41B89DFC70@git1-us-west.apache.org>
Date: Tue, 18 Apr 2017 11:53:11 +0000 (UTC)
archived-at: Tue, 18 Apr 2017 11:53:13 -0000

Github user koertkuipers commented on the issue:

    https://github.com/apache/spark/pull/17660
  
    I see. let me check if making leftHasNonNullPredicate and
    rightHasNonNullPredicate lazy solves it then
    
    On Apr 17, 2017 23:44, "Wenchen Fan" <notifications@github.com> wrote:
    
    > I think the root problem is, in EliminateOuterJoin.buildNewJoinType, we
    > always build leftHasNonNullPredicate and rightHasNonNullPredicate. If
    > it's left join, only rightHasNonNullPredicate is used, and when building
    > leftHasNonNullPredicate, we may pass null values to a UDF that is not
    > supposed to run on null values.
    >
    > —
    > You are receiving this because you authored the thread.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/spark/pull/17660#issuecomment-294667709>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe-auth/AAyIJHOCvy6X0JVDoID_H3cDGYMZKGLUks5rxDG4gaJpZM4M_gRb>
    > .
    >


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org