spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rednaxelafx <...@git.apache.org>
Subject [GitHub] spark pull request #17777: [SPARK-20482][SQL] Resolving Casts is too strict ...
Date Wed, 26 Apr 2017 23:10:21 GMT
GitHub user rednaxelafx opened a pull request:

    https://github.com/apache/spark/pull/17777

    [SPARK-20482][SQL] Resolving Casts is too strict on having time zone set

    ## What changes were proposed in this pull request?
    
    Relax the requirement that a `TimeZoneAwareExpression` has to have its `timeZoneId` set
to be considered resolved.
    With this change, a `Cast` (which is a `TimeZoneAwareExpression`) can be considered resolved
if the `(fromType, toType)` combination doesn't require time zone information.
    
    Also de-relaxed test cases in `CastSuite` so Casts in that test suite don't get a default`timeZoneId
= Option("GMT")`.
    
    ## How was this patch tested?
    
    Ran the de-relaxed`CastSuite` and it's passing. Also ran the SQL unit tests and they're
passing too.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rednaxelafx/apache-spark fix-catalyst-cast-timezone

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17777.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17777
    
----
commit 8b21a41a7e423ea9ca2328991c98fd558647c30d
Author: Kris Mok <kris.mok@databricks.com>
Date:   2017-04-26T22:58:36Z

    Relax the requirement that a TimeZoneAwareExpression has to have its timeZoneId set to
be considered resolved.
    With this change, a Cast (which is a TimeZoneAwareExpression) can be considered resolved
if the (fromType, toType)
    combination doesn't require time zone information.
    
    Also de-relaxed test cases in CastSuite so Casts in that test suite don't get a timeZoneId
by default.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message