spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark issue #17807: [SPARK-20532][SPARKR] Implement grouping and grouping_id
Date Sun, 30 Apr 2017 19:09:57 GMT
Github user felixcheung commented on the issue:

    https://github.com/apache/spark/pull/17807
  
    I understanding what you are saying and for frequent R users this might not really be
a big issue, so far we are taking the view of avoiding masking any inconvenience, if we if
at all could.
    
    Ideally, I'd prefer to eliminate any conflict with `cov`, `filter`, and `sample` as well.
    This is what I'm referring to re: the workaround for [drop](https://github.com/apache/spark/blob/master/R/pkg/R/DataFrame.R#L3288).
If the signature isn't too strange or different, we should try to export a generic + stub
that makes the base:: function still callable without a namespace prefix.
    
    From a quick check I think what we have for `drop` could apply to `grouping` as well -
would you like to give it a shot?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message