spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sethah <...@git.apache.org>
Subject [GitHub] spark pull request #15435: [SPARK-17139][ML] Add model summary for Multinomi...
Date Fri, 28 Apr 2017 06:04:41 GMT
Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15435#discussion_r113856908
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
    @@ -1070,90 +1096,128 @@ private[classification] class MultiClassSummarizer extends Serializable
{
     }
     
     /**
    - * Abstraction for multinomial Logistic Regression Training results.
    - * Currently, the training summary ignores the training weights except
    - * for the objective trace.
    - */
    -sealed trait LogisticRegressionTrainingSummary extends LogisticRegressionSummary {
    -
    -  /** objective function (scaled loss + regularization) at each iteration. */
    -  def objectiveHistory: Array[Double]
    -
    -  /** Number of training iterations until termination */
    -  def totalIterations: Int = objectiveHistory.length
    -
    -}
    -
    -/**
    - * Abstraction for Logistic Regression Results for a given model.
    + * Abstraction for logistic regression results for a given model.
      */
     sealed trait LogisticRegressionSummary extends Serializable {
     
       /**
        * Dataframe output by the model's `transform` method.
        */
    +  @Since("2.2.0")
    --- End diff --
    
    We have avoided putting since tags on methods inside traits. But since this is sealed
and I don't think we intend to add to it, it should be ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message