spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark pull request #17640: [SPARK-17608][SPARKR]:Long type has incorrect ser...
Date Fri, 28 Apr 2017 04:39:08 GMT
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17640#discussion_r113851363
  
    --- Diff: R/pkg/R/serialize.R ---
    @@ -83,6 +83,7 @@ writeObject <- function(con, object, writeType = TRUE) {
              Date = writeDate(con, object),
              POSIXlt = writeTime(con, object),
              POSIXct = writeTime(con, object),
    +         bigint = writeDouble(con, object),
    --- End diff --
    
    if you are referring to https://github.com/apache/spark/blob/master/R/pkg/R/types.R#L25
    like it says, `names(PRIMITIVE_TYPES) are Scala types whereas
    # values are equivalent R types.` so `bigint` there is Scala type, not R type


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message