spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From holdenk <...@git.apache.org>
Subject [GitHub] spark pull request #17688: [MINOR][DOCS][PYTHON] Adding missing boolean type...
Date Sun, 23 Apr 2017 02:55:10 GMT
Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17688#discussion_r112823550
  
    --- Diff: python/pyspark/sql/dataframe.py ---
    @@ -1238,7 +1238,7 @@ def fillna(self, value, subset=None):
                 Value to replace null values with.
                 If the value is a dict, then `subset` is ignored and `value` must be a mapping
                 from column name (string) to replacement value. The replacement value must
be
    -            an int, long, float, or string.
    +            an int, long, float, boolean, or string.
    --- End diff --
    
    That makes sense, I'd say that the eventual improvement would maybe be offering `fill`
for bool for symetry with the rest of the types but its not necessary here rather than type
checking for bool on the input.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message