spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yangyangyyy <...@git.apache.org>
Subject [GitHub] spark pull request #17697: [SPARK-20414][MLLIB] avoid creating only 16 reduc...
Date Fri, 21 Apr 2017 21:50:50 GMT
Github user yangyangyyy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17697#discussion_r112783447
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/rdd/MLPairRDDFunctions.scala ---
    @@ -39,8 +39,8 @@ class MLPairRDDFunctions[K: ClassTag, V: ClassTag](self: RDD[(K, V)])
extends Se
        * @param ord the implicit ordering for T
        * @return an RDD that contains the top k values for each key
        */
    -  def topByKey(num: Int)(implicit ord: Ordering[V]): RDD[(K, Array[V])] = {
    -    self.aggregateByKey(new BoundedPriorityQueue[V](num)(ord))(
    +  def topByKey(num: Int, bucketsCount: Int = 200)(implicit ord: Ordering[V]): RDD[(K,
Array[V])] = {
    --- End diff --
    
    @HyukjinKwon   yes , updated that way



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message