spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request #17708: [SPARK-20413] Add new query hint NO_COLLAPSE.
Date Thu, 20 Apr 2017 17:29:55 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17708#discussion_r112505928
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
    @@ -387,6 +387,13 @@ case class BroadcastHint(child: LogicalPlan) extends UnaryNode {
     }
     
     /**
    + * A hint for the optimizer that we should not merge two projections.
    + */
    +case class NoCollapseHint(child: LogicalPlan) extends UnaryNode {
    --- End diff --
    
    Can you explain why we want this in the LogicalPlan level and not on the expression level?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message