spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jerryshao <...@git.apache.org>
Subject [GitHub] spark pull request #17638: [SPARK-20338][CORE]Spaces in spark.eventLog.dir a...
Date Thu, 20 Apr 2017 13:12:26 GMT
Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17638#discussion_r112448477
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
    @@ -50,22 +49,22 @@ import org.apache.spark.util.{JsonProtocol, Utils}
     private[spark] class EventLoggingListener(
         appId: String,
         appAttemptId : Option[String],
    -    logBaseDir: URI,
    +    logBaseDir: String,
         sparkConf: SparkConf,
         hadoopConf: Configuration)
       extends SparkListener with Logging {
     
       import EventLoggingListener._
     
    -  def this(appId: String, appAttemptId : Option[String], logBaseDir: URI, sparkConf:
SparkConf) =
    +  def this(appId: String, appAttemptId : Option[String], logBaseDir: String, sparkConf:
SparkConf) =
         this(appId, appAttemptId, logBaseDir, sparkConf,
           SparkHadoopUtil.get.newConfiguration(sparkConf))
     
       private val shouldCompress = sparkConf.getBoolean("spark.eventLog.compress", false)
       private val shouldOverwrite = sparkConf.getBoolean("spark.eventLog.overwrite", false)
       private val testing = sparkConf.getBoolean("spark.eventLog.testing", false)
       private val outputBufferSize = sparkConf.getInt("spark.eventLog.buffer.kb", 100) *
1024
    -  private val fileSystem = Utils.getHadoopFileSystem(logBaseDir, hadoopConf)
    --- End diff --
    
    This probably a by design choice, only when scheme is defined then Spark will pick the
right FS, otherwise it will use local FS instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message