spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maropu <...@git.apache.org>
Subject [GitHub] spark pull request #17191: [SPARK-14471][SQL] Aliases in SELECT could be use...
Date Wed, 19 Apr 2017 06:49:23 GMT
Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17191#discussion_r112126273
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
    @@ -2349,7 +2350,22 @@ class Analyzer(
       }
     
       /**
    -   * Replace [[TimeZoneAwareExpression]] without timezone id by its copy with session
local
    +   * Replace unresolved expressions in grouping keys with resolved ones in SELECT clauses.
    +   */
    +  object ResolveAggAliasInGroupBy extends Rule[LogicalPlan] {
    +
    +    override def apply(plan: LogicalPlan): LogicalPlan = plan.resolveOperators {
    +      case agg @ Aggregate(groups, aggs, child)
    +          if conf.groupByAliases && child.resolved && groups.exists(!_.resolved)
=>
    +        agg.copy(groupingExpressions = groups.map {
    +          case u: UnresolvedAttribute => aggs.find(ne => resolver(ne.name, u.name)).getOrElse(u)
    --- End diff --
    
    okay, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message