spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #17675: [SPARK-20036][DOC] Note incompatible dependencies...
Date Tue, 18 Apr 2017 21:26:30 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17675#discussion_r112068489
  
    --- Diff: docs/streaming-kafka-0-10-integration.md ---
    @@ -12,6 +12,8 @@ For Scala/Java applications using SBT/Maven project definitions, link
your strea
     	artifactId = spark-streaming-kafka-0-10_{{site.SCALA_BINARY_VERSION}}
     	version = {{site.SPARK_VERSION_SHORT}}
     
    +**Do not** manually add dependencies on org.apache.kafka artifacts (e.g. kafka-clients).
 The spark-streaming-kafka-0-10 artifact has the appropriate transitive dependencies already,
and different versions may be incompatible in hard to diagnose ways.
    --- End diff --
    
    I suppose that if the app is using kafka APIs directly it should declare a direct dependency
on it, but, harmonize the versions. That said, that's error prone, so this seems OK. If you
make further changes to the text here can you back-tick the artifact names for readability?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message