spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From steveloughran <...@git.apache.org>
Subject [GitHub] spark pull request #9571: [SPARK-11373] [CORE] Add metrics to the History Se...
Date Tue, 18 Apr 2017 09:58:20 GMT
Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9571#discussion_r111914872
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala
---
    @@ -99,6 +104,19 @@ private[history] abstract class ApplicationHistoryProvider {
       }
     
       /**
    +   * Bind to the History Server: threads should be started here; exceptions may be raised
    +   * Start the provider: threads should be started here; exceptions may be raised
    +   * if the history provider cannot be started.
    +   * The base implementation contains a re-entrancy check and should
    --- End diff --
    
    All the work on Yarn service model, and that of SmartFrog before it, have given me a fear
of startup logic. I'll see about doing it there though


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message