spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #17655: [SPARK-20156] [SQL] [FOLLOW-UP] Java String toLow...
Date Mon, 17 Apr 2017 07:06:31 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17655#discussion_r111713226
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
    @@ -2295,5 +2295,27 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
             }
           }
         }
    +
    +    test(s"basic DDL using locale tr - caseSensitive $caseSensitive") {
    +      withSQLConf(SQLConf.CASE_SENSITIVE.key -> s"$caseSensitive") {
    +        withLocale("tr") {
    +          val dbName = "DaTaBaSeI"
    +          withDatabase(dbName) {
    +            sql(s"CREATE DATABASE $dbName")
    +            sql(s"USE $dbName")
    +
    +            val tabName = "tAbI"
    +            withTable(tabName) {
    +              sql(s"CREATE TABLE $tabName(c1 int) USING PARQUET")
    +              sql(s"INSERT OVERWRITE TABLE $tabName SELECT 1")
    +              checkAnswer(sql(s"SELECT c1 FROM $tabName"), Row(1) :: Nil)
    +              sql(s"DROP TABLE $tabName")
    +            }
    +
    +            sql(s"DROP DATABASE $dbName")
    --- End diff --
    
    is this needed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message