spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #17540: [SPARK-20213][SQL][UI] Fix DataFrameWriter operat...
Date Mon, 17 Apr 2017 04:07:22 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17540#discussion_r111703744
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -180,9 +180,9 @@ class Dataset[T] private[sql](
         // to happen right away to let these side effects take place eagerly.
         queryExecution.analyzed match {
           case c: Command =>
    -        LocalRelation(c.output, queryExecution.executedPlan.executeCollect())
    +        LocalRelation(c.output, withAction("collect", queryExecution)(_.executeCollect()))
           case u @ Union(children) if children.forall(_.isInstanceOf[Command]) =>
    -        LocalRelation(u.output, queryExecution.executedPlan.executeCollect())
    +        LocalRelation(u.output, withAction("collect", queryExecution)(_.executeCollect()))
    --- End diff --
    
    shall we only add execution id for commands that will trigger execution? AFAIK there are
3 commands: `CreateDataSourceTableAsSelectCommand`, `CreateHiveTableAsSelectCommand` and `CacheTable`.
We can call `SQLExecution.withNewExecutionId` inside these 3 commands.
    
    Then we don't need to worry about nested execution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message