spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #17568: [SPARK-20254][SQL] Remove unnecessary data conver...
Date Mon, 17 Apr 2017 02:03:20 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17568#discussion_r111697946
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/objects.scala
---
    @@ -96,3 +98,30 @@ object CombineTypedFilters extends Rule[LogicalPlan] {
         }
       }
     }
    +
    +/**
    + * Removes MapObjects when the following conditions are satisfied
    + *   1. Mapobject(e) where e is lambdavariable(), which means types for input output
    + *      are primitive types
    + *   2. no custom collection class specified
    + * representation of data item.  For example back to back map operations.
    + */
    +object EliminateMapObjects extends Rule[LogicalPlan] {
    +  def apply(plan: LogicalPlan): LogicalPlan = plan transform {
    +    case _ @ DeserializeToObject(Invoke(
    +        MapObjects(_, _, _, Cast(LambdaVariable(_, _, dataType, _), castDataType, _),
    +          inputData, None),
    +        funcName, returnType: ObjectType, arguments, propagateNull, returnNullable),
    +        outputObjAttr, child) if dataType == castDataType =>
    --- End diff --
    
    The order does not matter. The batch will be run multiple times. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message