spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiszk <...@git.apache.org>
Subject [GitHub] spark pull request #17436: [SPARK-20101][SQL] Use OffHeapColumnVector when "...
Date Wed, 12 Apr 2017 12:06:11 GMT
Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17436#discussion_r111131172
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
    @@ -90,6 +91,8 @@
        */
       private ColumnarBatch columnarBatch;
     
    +  private MemoryMode memoryMode = null;
    --- End diff --
    
    This is because `initBatch()` has to distinguish two cases. 
    1. `initBatch()` is called without calling `initBatch(partitionColumns, partitionValues,
isEnabledOffHeap)`
    2. `initBatch()` is called after `initBatch(partitionColumns, partitionValues, isEnabledOffHeap)`
was called.
    
    In the case 2., we have to keep the memory mode that has been set by `initBatch(partitionColumns,
partitionValues, isEnabledOffHeap)`.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message