spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jerryshao <...@git.apache.org>
Subject [GitHub] spark pull request #17620: [SPARK-20305][Spark Core]Master may keep in the s...
Date Wed, 12 Apr 2017 10:06:37 GMT
Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17620#discussion_r111111204
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ---
    @@ -539,7 +539,7 @@ private[deploy] class Master(
     
       private def completeRecovery() {
         // Ensure "only-once" recovery semantics using a short synchronization period.
    -    if (state != RecoveryState.RECOVERING) { return }
    +    if (state != RecoveryState.RECOVERING && state != RecoveryState.COMPLETING_RECOVERY)
{ return }
    --- End diff --
    
    @lvdongr would you please explain what will be happened after this change? With your change,
which code will call this `completeRecovery`? I see there're 4 places which will call this
`completeRecovery`.
    
    Also if we have exception during recovery, should we fail fast?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message