spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #16820: [SPARK-19471] AggregationIterator does not initia...
Date Sat, 08 Apr 2017 17:43:25 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16820#discussion_r110523513
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
    @@ -448,6 +448,22 @@ class DataFrameFunctionsSuite extends QueryTest with SharedSQLContext
{
           rand(Random.nextLong()), randn(Random.nextLong())
         ).foreach(assertValuesDoNotChangeAfterCoalesceOrUnion(_))
       }
    +
    +  private def assertNoExceptions(c: Column): Unit = {
    +    for (wholeStage <- Seq(true, false)) {
    +      withSQLConf((SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key, wholeStage.toString)) {
    +        spark.range(0, 5).toDF("a").agg(sum("a")).withColumn("v", c).collect()
    --- End diff --
    
    I found almost all the physical plans of join have the exactly same issue. I will try
to submit the fix for the joins one by one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message