spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dilipbiswal <...@git.apache.org>
Subject [GitHub] spark pull request #17537: [SPARK-20204][SQL][Followup] SQLConf should react...
Date Wed, 05 Apr 2017 16:05:35 GMT
Github user dilipbiswal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17537#discussion_r109958292
  
    --- Diff: core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala
---
    @@ -51,6 +52,26 @@ class ConfigEntrySuite extends SparkFunSuite {
         assert(conf.get(dConf) === 20.0)
       }
     
    +  test("conf entry: timezone") {
    +    val tzStart = TimeZone.getDefault().getID()
    --- End diff --
    
    @cloud-fan Thank you :-). Its so much simpler. I somehow was trying to use the exact same
function that we use in the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message