spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From samelamin <...@git.apache.org>
Subject [GitHub] spark pull request #17487: [Spark-20145] Fix range case insensitive bug in S...
Date Sun, 02 Apr 2017 12:38:16 GMT
Github user samelamin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17487#discussion_r109307649
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
    @@ -105,7 +105,7 @@ object ResolveTableValuedFunctions extends Rule[LogicalPlan] {
     
       override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
         case u: UnresolvedTableValuedFunction if u.functionArgs.forall(_.resolved) =>
    -      builtinFunctions.get(u.functionName) match {
    +      builtinFunctions.get(u.functionName.toLowerCase) match {
    --- End diff --
    
    So would you like me to revert the change to the case class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message