Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: dbtsai <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-15628-spark@git.apache.org>
In-Reply-To: <git-pr-15628-spark@git.apache.org>
Subject: [GitHub] spark pull request #15628: [SPARK-17471][ML] Add compressed method to ML mat...
Content-Type: text/plain
Message-Id: <20170324181442.A25EFDFFDA@git1-us-west.apache.org>
Date: Fri, 24 Mar 2017 18:14:42 +0000 (UTC)
archived-at: Fri, 24 Mar 2017 18:14:47 -0000

Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15628#discussion_r107961223
  
    --- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
    @@ -161,6 +168,116 @@ sealed trait Matrix extends Serializable {
        */
       @Since("2.0.0")
       def numActives: Int
    +
    +  /**
    +   * Converts this matrix to a sparse matrix.
    +   *
    +   * @param colMajor Whether the values of the resulting sparse matrix should be in column major
    +   *                    or row major order. If `false`, resulting matrix will be row major.
    +   */
    +  private[ml] def toSparseMatrix(colMajor: Boolean): SparseMatrix
    +
    +  /**
    +   * Converts this matrix to a sparse matrix in column major order.
    +   */
    +  @Since("2.2.0")
    +  def toSparseColMajor: SparseMatrix = toSparseMatrix(colMajor = true)
    +
    +  /**
    +   * Converts this matrix to a sparse matrix in row major order.
    +   */
    +  @Since("2.2.0")
    +  def toSparseRowMajor: SparseMatrix = toSparseMatrix(colMajor = false)
    +
    +  /**
    +   * Converts this matrix to a sparse matrix while maintaining the layout of the current matrix.
    +   */
    +  @Since("2.2.0")
    +  def toSparse: SparseMatrix = toSparseMatrix(colMajor = !isTransposed)
    +
    +  /**
    +   * Converts this matrix to a dense matrix.
    +   *
    +   * @param colMajor Whether the values of the resulting dense matrix should be in column major
    +   *                    or row major order. If `false`, resulting matrix will be row major.
    +   */
    +  private[ml] def toDenseMatrix(colMajor: Boolean): DenseMatrix
    +
    +  /**
    +   * Converts this matrix to a dense matrix while maintaining the layout of the current matrix.
    +   */
    +  @Since("2.2.0")
    +  def toDense: DenseMatrix = toDenseMatrix(colMajor = !isTransposed)
    --- End diff --
    
    `def toDense: DenseMatrix = toDenseMatrix(colMajor = isColMajor)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org