Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: gatorsmile <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-17392-spark@git.apache.org>
In-Reply-To: <git-pr-17392-spark@git.apache.org>
Subject: [GitHub] spark pull request #17392: [SPARK-20008] [SQL] DISTINCT and EXCEPT Support o...
Content-Type: text/plain
Message-Id: <20170323011105.27125DFE1D@git1-us-west.apache.org>
Date: Thu, 23 Mar 2017 01:11:05 +0000 (UTC)
archived-at: Thu, 23 Mar 2017 01:11:07 -0000

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17392#discussion_r107569402
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ObjectHashAggregateExec.scala ---
    @@ -147,9 +147,13 @@ case class ObjectHashAggregateExec(
     
     object ObjectHashAggregateExec {
       def supportsAggregate(aggregateExpressions: Seq[AggregateExpression]): Boolean = {
    -    aggregateExpressions.map(_.aggregateFunction).exists {
    -      case _: TypedImperativeAggregate[_] => true
    -      case _ => false
    +    if (aggregateExpressions.isEmpty) {
    +      false
    --- End diff --
    
    not needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org