Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: zsxwing <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-17209-spark@git.apache.org>
In-Reply-To: <git-pr-17209-spark@git.apache.org>
Subject: [GitHub] spark pull request #17209: [SPARK-19853][SS] uppercase kafka topics fail whe...
Content-Type: text/plain
Message-Id: <20170312045147.CEC80F16B2@git1-us-west.apache.org>
Date: Sun, 12 Mar 2017 04:51:47 +0000 (UTC)
archived-at: Sun, 12 Mar 2017 04:51:55 -0000

Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17209#discussion_r105548819
  
    --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala ---
    @@ -606,6 +607,36 @@ class KafkaSourceSuite extends KafkaSourceTest {
         assert(query.exception.isEmpty)
       }
     
    +  for((optionKey, optionValue, answer) <- Seq(
    +    (STARTING_OFFSETS_OPTION_KEY, "earLiEst", EarliestOffsetRangeLimit),
    +    (ENDING_OFFSETS_OPTION_KEY, "laTest", LatestOffsetRangeLimit),
    +    (STARTING_OFFSETS_OPTION_KEY, """{"topic-A":{"0":23}}""",
    +      SpecificOffsetRangeLimit(Map(new TopicPartition("topic-A", 0) -> 23))))) {
    +    test(s"test offsets containing uppercase characters (${answer.getClass.getSimpleName})") {
    +      val offset = getKafkaOffsetRangeLimit(
    +        Map(optionKey -> optionValue),
    +        optionKey,
    +        answer
    +      )
    +
    +      assert(offset == answer)
    +    }
    +  }
    +
    +  for((optionKey, answer) <- Seq(
    --- End diff --
    
    Same as above


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org