Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: budde <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-16944-spark@git.apache.org>
In-Reply-To: <git-pr-16944-spark@git.apache.org>
Subject: [GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...
Content-Type: text/plain
Message-Id: <20170307064817.70543DFFF0@git1-us-west.apache.org>
Date: Tue,  7 Mar 2017 06:48:17 +0000 (UTC)
archived-at: Tue, 07 Mar 2017 06:48:19 -0000

Github user budde commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16944#discussion_r104598894
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala ---
    @@ -476,46 +476,6 @@ object ParquetFileFormat extends Logging {
       }
     
       /**
    -   * Reconciles Hive Metastore case insensitivity issue and data type conflicts between Metastore
    -   * schema and Parquet schema.
    -   *
    -   * Hive doesn't retain case information, while Parquet is case sensitive. On the other hand, the
    -   * schema read from Parquet files may be incomplete (e.g. older versions of Parquet doesn't
    -   * distinguish binary and string).  This method generates a correct schema by merging Metastore
    -   * schema data types and Parquet schema field names.
    -   */
    -  def mergeMetastoreParquetSchema(
    -      metastoreSchema: StructType,
    -      parquetSchema: StructType): StructType = {
    -    def schemaConflictMessage: String =
    -      s"""Converting Hive Metastore Parquet, but detected conflicting schemas. Metastore schema:
    -         |${metastoreSchema.prettyJson}
    -         |
    -         |Parquet schema:
    -         |${parquetSchema.prettyJson}
    -       """.stripMargin
    -
    -    val mergedParquetSchema = mergeMissingNullableFields(metastoreSchema, parquetSchema)
    --- End diff --
    
    Oversight on my part. Removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org